fix(tool): swap inverted file_read line range instead of erroring - #1222
Open
seamnniel wants to merge 1 commit into
Open
fix(tool): swap inverted file_read line range instead of erroring#1222seamnniel wants to merge 1 commit into
seamnniel wants to merge 1 commit into
Conversation
|
|
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_readhard-errors when the model passesend_line < start_line:This is a common model slip — the model derives
start_linefrom the old side of a diff hunk whileend_linecomes from the new file's length. One bad call fails the whole file's review item (observed: 6/6 items in a review failed this way).Fix: swap the inverted range and serve it. The response still reports
Total lines, so the model can recover if the swap was not its intent. UpdatedTestExecute_InvalidLineRangetoTestExecute_SwappedLineRangeasserting the swapped range returns content.Validation
go test ./internal/tool/— passmake check— passocr llm testandocr review --commit <sha> -pwork.Disclosure
This change was developed with AI assistance (Devin / SWE-2) per the project's agent guidelines; the change was reviewed and tested before submission.