[Bug] Fix TOCTOU race condition and unsafe lazy init in CacheItem.initConfigGrayIfEmpty()#14934
Open
LiyunZhang10 wants to merge 1 commit intoalibaba:developfrom
Open
Conversation
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
…tConfigGrayIfEmpty()
e5913a3 to
cedbe4d
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
In
CacheItem.java,configCacheGraywas lazily initialized using a non-thread-safeHashMapand without synchronization (missing Double-Checked Locking). When multiple threads callinitConfigGrayIfEmpty(grayName)concurrently, multipleHashMaps could be created, overwriting each other and causing memory leak and data loss.Additionally, the method used a check-then-act pattern (
containsKey+put) which is not atomic. In high-concurrency gray release configurations, this could lead to multiplecreateConfigCacheGray()executions for the samegrayName, and throwingConcurrentModificationExceptiondue to the non-thread-safeHashMapimplementation.Proposed Changes
configCacheGray(which is alreadyvolatile).configCacheGray's underlying implementation fromHashMaptoConcurrentHashMapto ensure thread safety during concurrent structural modifications.containsKey+putpattern withcomputeIfAbsent()to guarantee thatConfigCacheFactoryDelegate.createConfigCacheGray()is executed exactly once pergrayName, effectively eliminating the TOCTOU hazard and preventing corrupted pointers that could lead to NPE in the routing layer.General Checklist