fix(github/environment): omit plan-gated protection fields unless set - #1373
Open
0x0f0f0f wants to merge 1 commit into
Open
fix(github/environment): omit plan-gated protection fields unless set#13730x0f0f0f wants to merge 1 commit into
0x0f0f0f wants to merge 1 commit into
Conversation
createOrUpdateEnvironment always sent wait_timer, prevent_self_review and
reviewers — explicit defaults (0/false/null) when the props were unset. On a
private repository without an Enterprise plan that field family is plan-gated,
and GitHub 422s ("Failed to create the environment protection rule") when the
fields are present at all, defaults included — making Environment unusable on
private Free/Pro/Team repositories.
Send each field only when its prop is set now or was set before: never-set
fields are omitted (plan-gated repos work), while removing a previously-set
prop still sends the explicit default so removal converges — a repository that
held the value demonstrably supports the field. deployment_branch_policy is
available on all plans and keeps its explicit null.
The Environment test suite already works around this gate ("The host
repository is public because environments (and their protection rules) on
private repositories are plan-gated"); this makes the provider itself honor
it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createOrUpdateEnvironmentalways sentwait_timer,prevent_self_reviewandreviewers, explicit defaults (0/false/null) when the props were unset. On a private repository without an Enterprise plan that field family is plan-gated, and GitHub 422s ("Failed to create the environment protection rule") when the fields are present at all, defaults included, making Environment unusable on private Free/Pro/Team repositories.Send each field only when its prop is set now or was set before: never-set fields are omitted (plan-gated repos work), while removing a previously-set prop still sends the explicit default so removal converges: a repository that held the value demonstrably supports the field.
deployment_branch_policyis available on all plans and keeps its explicit null.The Environment test suite already works around this gate ("The host repository is public because environments (and their protection rules) on private repositories are plan-gated"); this makes the provider itself honor it.