fix(platform): skip absent optional config bindings - #1354
Open
aryasaatvik wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip synthetic runtime bindings for optional configuration fields that are absent, while preserving bindings for concrete configuration values.
Behavior
The plan phase now rejects empty paths and
undefinedvalues before publishing a binding. The runtime phase also ignores empty keys instead of attempting an invalid lookup.Validation
mise exec bun@1.3.13 -- bun node_modules/alchemy-test/bin/alchemy-test.ts --sequential test/PlatformConfigBindings.test.ts0 failed | 1 passedScope
This only changes configuration binding publication; it does not alter required configuration resolution or runtime provider behavior.