fix(test): keep Vitest sidecar alive through teardown - #1341
Open
dmmulroy wants to merge 1 commit into
Open
Conversation
sam-goodwin
added a commit
that referenced
this pull request
Aug 25, 2026
…r + Bun adapter) Companion to #1341's Vitest aroundAll fix — the other two adapters had the same class of leak, each with a different trigger: - alchemy-test runner: runAfterAll short-circuited on the first failing hook, so a failing teardown assertion dropped every later afterAll — including Test.make's fallback that closes the shared scope and local provider sidecar. afterAll hooks now all run; failures aggregate. - Test/Bun: bun:test stops the afterAll chain once a hook throws (verified empirically; registration order and afterAll-after-failed- beforeAll are fine), skipping the microtask-registered fallback. The adapter now guards user teardowns: on failure it runs the idempotent cleanup before rethrowing. Both regression tests are red against the previous code. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep
alchemy/Test/Vitest's shared scope and local provider sidecar alive through application teardown hooks.Vitest's default stack ordering reverses
afterAllhooks, so the microtask-registered fallback ran before user hooks.aroundAllowns the complete suite lifecycle across hook-order modes and still tears down after failed setup or teardown.The regression runs real Vitest through the public adapter. The corrected workerd reproduction is red on
alchemy@2.0.0-beta.72and green with this change, without moving telemetry onto the request path.Addresses the local teardown failure reported in #1331.