[review] batch6 fixes: 10 articles (1 high + 4 medium + 4 low)#778
Merged
Conversation
Addresses findings from batch6-merged-pr-kb-review-2026-05-30.html codex review of the 37 merged convert PRs. High (1): - VM application traffic times out behind kube-ovn Geneve overlay… remove 12 leaked phase2/phase4/phase5 evidence-note lines from the published article body (pipeline scratch notes leaked into prose). Medium (4): - OpenTelemetry Apache HTTPD auto-instrumentation fails to inject… Rewrite resolution as 2 steps: step 1 remove the actual conflicting user mount (root cause); step 2 the extra emptyDir as empirical mitigation when no overlap is visible. - KubeVirt VM Loses Bridge Network Connectivity When br_netfilter… Add a "Disruptive node-level change" block with maintenance-window scheduling, rollback steps (capture prior sysctl/module-list state), third-party-agent audit guidance, and a note that durable fix is preventing the workload from running on the affected node, not just unloading the module once. - TektonConfig stuck Not Ready after Tekton operator upgrade… Reorder: try re-create installer set first (operator-aware path); force finalizer=null is last resort with preconditions (deletionTimestamp set, only the controller's finalizer present, spec backed up, customer ack, owner-controller failure confirmed). - VolumeSnapshot creation latency from stale VolumeSnapshotContent… Add explicit destructive-operation warning before the delete: with DeletionPolicy=Delete the snapshot-controller issues a backend DeleteSnapshot. Document the patch-to-Retain alternative + backup pipeline + customer-ack preconditions. Low (4): - PipelineRun stuck in PipelineRunPending… Rename "## Evidence" -> "## Verification" and drop the internal ev:c1/c3/c6/c7 labels. - Dynamic NFS storage provisioning for Tekton CI/CD on ACP Strip "cluster glean-lab-base-0529" mentions from user-facing prose. - ResolutionRequest reconciles every ten hours and why that is harmless Strip "lab-base" mentions from user-facing prose. - Alertmanager 0.27+ UTF-8 matchers parser warning… + Custom matchers with whitespace trigger Alertmanager UTF-8 parser… Add "## See Also" cross-link between the two near-duplicate KBs so they don't drift independently.
Contributor
WalkthroughTen knowledge-base articles are updated with cross-references between related topics, removal of cluster-specific identifiers to improve applicability, addition of pre-execution safety warnings for destructive operations, and refinement of resolution procedures with clearer step ordering and preconditions. ChangesKnowledge Base Documentation Improvements
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/en/solutions/ResolutionRequest_reconciles_every_ten_hours_and_why_that_is_harmless.md (1)
18-18:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winCluster-specific identifier remains in Root Cause section.
The PR objectives indicate removing "lab-base mentions from user-facing prose." Line 18 contains "on lab-base the live
deploy/tekton-pipelines-remote-resolvers..." which appears to be a cluster-specific reference. Consider generalizing this to "on a stock ACP cluster" or similar to match the sanitization applied to other articles in this batch.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/en/solutions/ResolutionRequest_reconciles_every_ten_hours_and_why_that_is_harmless.md` at line 18, Replace the cluster-specific phrase "lab-base" in the sentence that reads "on lab-base the live `deploy/tekton-pipelines-remote-resolvers`..." with a generic descriptor such as "on a stock ACP cluster" (leave the resource name `deploy/tekton-pipelines-remote-resolvers` unchanged and preserve backticks); update the surrounding prose to match the sanitized style used elsewhere so the sentence reads naturally and contains no environment-specific identifiers.
🧹 Nitpick comments (2)
docs/en/solutions/Custom_matchers_with_whitespace_trigger_Alertmanager_UTF_8_parser_fallback_warning.md (1)
81-83: ⚡ Quick winConsider using hyperlinks instead of plain text references.
The cross-reference correctly identifies the related article, but the same formatting concern applies here: backticks are unconventional for article titles, and a hyperlink would improve usability.
📎 Suggested improvement with relative link
## See Also -- `Alertmanager 0.27+ UTF-8 matchers parser warning for custom routing rules` — same root cause, broader walk-through of UTF-8-parser back-compat changes. +- [Alertmanager 0.27+ UTF-8 matchers parser warning for custom routing rules](./Alertmanager_027_UTF_8_matchers_parser_warning_for_custom_routing_rules.md) — same root cause, broader walk-through of UTF-8-parser back-compat changes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/en/solutions/Custom_matchers_with_whitespace_trigger_Alertmanager_UTF_8_parser_fallback_warning.md` around lines 81 - 83, Replace the plain backticked reference in the "See Also" section — specifically the entry "`Alertmanager 0.27+ UTF-8 matchers parser warning for custom routing rules`" — with a properly formatted hyperlink using the article title (no backticks) and a relative URL to that related doc; update the bullet to read like a linkable title (e.g., Alertmanager 0.27+ UTF-8 matchers parser warning for custom routing rules) and add the relative markdown link syntax so readers can click through.docs/en/solutions/Alertmanager_027_UTF_8_matchers_parser_warning_for_custom_routing_rules.md (1)
86-88: ⚡ Quick winConsider using hyperlinks instead of plain text references.
The cross-reference correctly identifies the related article, but using backticks for article titles is unconventional (backticks typically denote code/literals in Markdown). More importantly, the reference is plain text rather than a clickable hyperlink, which reduces usability.
📎 Suggested improvement with relative link
## See Also -- `Custom matchers with whitespace trigger Alertmanager UTF-8 parser fallback warning` — same root cause, walks through the unquoted-whitespace example explicitly. +- [Custom matchers with whitespace trigger Alertmanager UTF-8 parser fallback warning](./Custom_matchers_with_whitespace_trigger_Alertmanager_UTF_8_parser_fallback_warning.md) — same root cause, walks through the unquoted-whitespace example explicitly.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/en/solutions/Alertmanager_027_UTF_8_matchers_parser_warning_for_custom_routing_rules.md` around lines 86 - 88, Under the "## See Also" section replace the backticked plain-text reference `Custom matchers with whitespace trigger Alertmanager UTF-8 parser fallback warning` with a proper Markdown hyperlink to that related article (use a relative link to the article's filename and keep the article title as the link text) so the entry becomes a clickable cross-reference instead of inline code-styled text.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/en/solutions/OpenTelemetry_Apache_HTTPD_auto_instrumentation_fails_to_inject_when_user_volumes_leave_no_room_for_the_agent.md`:
- Line 63: Update the ambiguous instruction at line 63 in the document so it
reflects that step 2 is conditional: replace "The resolution has two parts; do
both in order" with a clear instruction such as "Attempt step 1 first; apply
step 2 only if step 1 does not resolve the issue." Also scan and adjust the
subsequent phrasing that starts with "When step 1 does not visibly apply" so it
remains consistent with the new line 63 wording and clearly indicates step 2 is
a fallback rather than mandatory.
---
Outside diff comments:
In
`@docs/en/solutions/ResolutionRequest_reconciles_every_ten_hours_and_why_that_is_harmless.md`:
- Line 18: Replace the cluster-specific phrase "lab-base" in the sentence that
reads "on lab-base the live `deploy/tekton-pipelines-remote-resolvers`..." with
a generic descriptor such as "on a stock ACP cluster" (leave the resource name
`deploy/tekton-pipelines-remote-resolvers` unchanged and preserve backticks);
update the surrounding prose to match the sanitized style used elsewhere so the
sentence reads naturally and contains no environment-specific identifiers.
---
Nitpick comments:
In
`@docs/en/solutions/Alertmanager_027_UTF_8_matchers_parser_warning_for_custom_routing_rules.md`:
- Around line 86-88: Under the "## See Also" section replace the backticked
plain-text reference `Custom matchers with whitespace trigger Alertmanager UTF-8
parser fallback warning` with a proper Markdown hyperlink to that related
article (use a relative link to the article's filename and keep the article
title as the link text) so the entry becomes a clickable cross-reference instead
of inline code-styled text.
In
`@docs/en/solutions/Custom_matchers_with_whitespace_trigger_Alertmanager_UTF_8_parser_fallback_warning.md`:
- Around line 81-83: Replace the plain backticked reference in the "See Also"
section — specifically the entry "`Alertmanager 0.27+ UTF-8 matchers parser
warning for custom routing rules`" — with a properly formatted hyperlink using
the article title (no backticks) and a relative URL to that related doc; update
the bullet to read like a linkable title (e.g., Alertmanager 0.27+ UTF-8
matchers parser warning for custom routing rules) and add the relative markdown
link syntax so readers can click through.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5dc35976-593d-4671-8b72-22e70f315a1f
📒 Files selected for processing (10)
docs/en/solutions/Alertmanager_027_UTF_8_matchers_parser_warning_for_custom_routing_rules.mddocs/en/solutions/Custom_matchers_with_whitespace_trigger_Alertmanager_UTF_8_parser_fallback_warning.mddocs/en/solutions/Dynamic_NFS_storage_provisioning_for_Tekton_CICD_on_ACP.mddocs/en/solutions/KubeVirt_VM_Loses_Bridge_Network_Connectivity_When_br_netfilter_Is_Loaded_on_the_Worker.mddocs/en/solutions/OpenTelemetry_Apache_HTTPD_auto_instrumentation_fails_to_inject_when_user_volumes_leave_no_room_for_the_agent.mddocs/en/solutions/PipelineRun_stuck_in_PipelineRunPending_on_ACP_DevOps_Pipelines.mddocs/en/solutions/ResolutionRequest_reconciles_every_ten_hours_and_why_that_is_harmless.mddocs/en/solutions/TektonConfig_stuck_Not_Ready_after_Tekton_operator_upgrade_on_ACP.mddocs/en/solutions/VM_application_traffic_times_out_behind_kube_ovn_Geneve_overlay_when_the_secondary_network_MTU_exceeds_1400_on_ACP.mddocs/en/solutions/VolumeSnapshot_creation_latency_from_stale_VolumeSnapshotContent_objects_on_ACP.md
💤 Files with no reviewable changes (1)
- docs/en/solutions/VM_application_traffic_times_out_behind_kube_ovn_Geneve_overlay_when_the_secondary_network_MTU_exceeds_1400_on_ACP.md
| ## Resolution | ||
|
|
||
| Add a non-conflicting `volumeMount` path (e.g. `/tmp/.otel-instr-fix`) backed by a new `emptyDir` volume to the user's Deployment. This gives the OTel mutating webhook the headroom it needs to complete the Apache HTTPD instrumentation preparation steps so the merged layout is consistent. After the mitigation, the Apache HTTPD container no longer emits `No such file or directory` on startup and the OTel auto-instrumentation injection succeeds. | ||
| The resolution has two parts; do both in order, because step 1 addresses the root cause and step 2 is an empirical mitigation whose mechanism is not fully understood. |
Contributor
There was a problem hiding this comment.
Clarify whether both steps are required or conditional.
Line 63 states "do both in order," but line 67 introduces step 2 with "When step 1 does not visibly apply," suggesting step 2 is conditional and only needed if step 1 doesn't resolve the issue. Consider revising line 63 to something like "The resolution has two parts; attempt step 1 first, then apply step 2 if needed" to accurately reflect that step 2 is a fallback rather than always required.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@docs/en/solutions/OpenTelemetry_Apache_HTTPD_auto_instrumentation_fails_to_inject_when_user_volumes_leave_no_room_for_the_agent.md`
at line 63, Update the ambiguous instruction at line 63 in the document so it
reflects that step 2 is conditional: replace "The resolution has two parts; do
both in order" with a clear instruction such as "Attempt step 1 first; apply
step 2 only if step 1 does not resolve the issue." Also scan and adjust the
subsequent phrasing that starts with "When step 1 does not visibly apply" so it
remains consistent with the new line 63 wording and clearly indicates step 2 is
a fallback rather than mandatory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the 8 findings in
batch6-merged-pr-kb-review-2026-05-30.html(codex review of the 37 merged batch6 convert PRs).
10 files touched, +57 / -25 lines:
VM_application_traffic_times_out_behind_kube_ovn_Geneve…OpenTelemetry_Apache_HTTPD…KubeVirt_VM_Loses_Bridge_Network_Connectivity_When_br_netfilter…TektonConfig_stuck_Not_Ready…VolumeSnapshot_creation_latency…PipelineRun_stuck_in_PipelineRunPending…ev:c1/c3/c6/c7labels; replace with sanitised "## Verification"Dynamic_NFS_storage_provisioning_for_Tekton_CICD…glean-lab-base-0529" mentions from user-facing proseResolutionRequest_reconciles_every_ten_hours…Alertmanager_027_UTF_8…+Custom_matchers_with_whitespace…## See Alsocross-link between the two near-duplicate KBsTest plan
phase[0-9]/lab-base/ev:csubstrings in the published body ofVM_application_traffic_times_out_behind_kube_ovn_Geneve…🤖 Generated with Claude Code
Summary by CodeRabbit