Skip to content

feat(market): allow sequenced bid creation#2077

Open
chalabi2 wants to merge 1 commit into
mainfrom
chalabi/allow-bseq-bids
Open

feat(market): allow sequenced bid creation#2077
chalabi2 wants to merge 1 commit into
mainfrom
chalabi/allow-bseq-bids

Conversation

@chalabi2

Copy link
Copy Markdown
Contributor

Description

Closes: N/A

Allow CreateBid to accept nonzero BSeq values for sequenced provider bids.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • targeted the correct branch: main
  • provided a link to the relevant issue or specification: N/A
  • included the necessary unit and integration tests: existing handler tests
  • added a changelog entry to CHANGELOG.md: N/A
  • included comments for documenting Go code: N/A
  • updated the relevant documentation or specification: N/A
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

@chalabi2 chalabi2 requested a review from a team as a code owner June 24, 2026 17:32
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 467b891e-e542-4761-9e60-fa14d2bb457a

📥 Commits

Reviewing files that changed from the base of the PR and between c7e851a and 592b2dd.

📒 Files selected for processing (1)
  • x/market/handler/server.go
💤 Files with no reviewable changes (1)
  • x/market/handler/server.go

Walkthrough

CreateBid in x/market/handler/server.go no longer rejects bids with non-zero BSeq. The handler now continues to order lookup and the remaining bid validations for those requests.

Changes

CreateBid BSeq Validation Removal

Layer / File(s) Summary
Remove BSeq != 0 guard in CreateBid
x/market/handler/server.go
Deletes the early ErrInvalidBid check for msg.ID.BSeq != 0, so CreateBid proceeds to later validation steps.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

🐇 I hopped past the gate so neat,
No BSeq check to stop my feet.
The bid runs on, the path is clear,
To later checks and escrow near.
A tiny hop, a tidy stream,
Said Rabbit with a happy beam.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: CreateBid now allows nonzero BSeq values for sequenced bid creation.
Description check ✅ Passed The description directly describes the same CreateBid behavior change and is relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chalabi/allow-bseq-bids

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

Marked as stale; will be closed in five days.
Cut bait or go fishing!

@github-actions github-actions Bot added the stale label Jul 5, 2026
Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
@troian troian force-pushed the chalabi/allow-bseq-bids branch from c7e851a to 592b2dd Compare July 7, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants