-
Notifications
You must be signed in to change notification settings - Fork 26.7k
Docs: clarify cases where traditional functions are preferred #3221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Manvendra0023
wants to merge
4
commits into
airbnb:master
Choose a base branch
from
Manvendra0023:docs-arrow-function-clarification
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−0
Draft
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
005116e
Docs: clarify when traditional functions are preferred
Manvendra0023 74054f5
docs: align arrow function guidance with non-inline usage
Manvendra0023 d7b8211
docs: reframe arrow function guidance around recommended use cases
Manvendra0023 0043f4c
Update README.md
Manvendra0023 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -949,6 +949,45 @@ Other Style Guides | |
|
|
||
| > Why not? If you have a fairly complicated function, you might move that logic out into its own named function expression. | ||
|
|
||
| > **Note:** While arrow functions are recommended for anonymous callbacks, traditional | ||
| > function declarations or expressions are still preferred in certain scenarios where | ||
| > their behavior is more appropriate. | ||
| > | ||
| > **Prefer traditional functions when:** | ||
| > | ||
| > - You rely on **function hoisting**, such as calling a function before its definition. | ||
| > - You need a **dynamic `this` binding**, for example in object methods or DOM event handlers. | ||
| > - You require access to the **`arguments` object**, which is not available in arrow functions. | ||
| > | ||
| > **Examples:** | ||
| > | ||
| > ```js | ||
| > // Function hoisting | ||
| > initialize(); | ||
| > | ||
| > function initialize() { | ||
| > // setup logic | ||
| > } | ||
| > ``` | ||
| > | ||
| > ```js | ||
| > // Dynamic `this` binding (e.g. event handlers) | ||
| > const button = document.querySelector('button'); | ||
| > | ||
| > button.addEventListener('click', function () { | ||
| > this.classList.add('active'); | ||
|
Comment on lines
+975
to
+979
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is actually not a good idea; in event handlers, you should use the event object argument's |
||
| > }); | ||
| > ``` | ||
| > | ||
| > ```js | ||
| > // Using the `arguments` object | ||
| > function sum() { | ||
| > return Array.from(arguments).reduce((total, value) => total + value, 0); | ||
| > } | ||
| > ``` | ||
|
|
||
|
|
||
|
|
||
| ```javascript | ||
| // bad | ||
| [1, 2, 3].map(function (x) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.