Configure video player

[rin]

Just a tiny change so far. Don't merge yet.

[mischacolley]

@rin what is that status on this one? Just asking as I know it's a component we'll wanna use for the Hoodie Day landing page and homepage if we can implement blueprint intime @lulen11 @davidpaley ...

[mischacolley]

@rin @davidpaley as flagged here https://github.com/aimementoring/website/issues/836 looking at this as something want to impliment on the website real soon

[davidpaley]

Hey @mischacolley. I assumed that you mention this because of Apparel. First we need to solve the problem that we have between integrating blueprint into the website and then finish the video integration (with styles and everything).

[rin]

@mischacolley David and I are going to review this on Monday and then update this issue!

[rin]

So, the status of this is:
• I added react-player and styled it to look kinda … minimalistic . screenshot is here: #24 (comment)
• my main problem with it is that the README of react-player says Due to various restrictions, ReactPlayer is not guaranteed to function properly on mobile devices (see here https://github.com/CookPete/react-player#mobile-considerations ). It might be that this mainly applies to the youtube and the vimeo player, where react-player relies on the SDK of youtube/vimeo, and that it's only about the user having to tap the video so that it starts playing.
• suggestion: we could add react-player to the website to try it out (since we still have issues to integrate blueprint in the website anyway) and find out if it works for us (which would mean we would need to ask some people with different phones to test it). if it does, we can then add it to blueprint (and solve the problem to integrate blueprint into the website!).

[lulen11]

@kbardi @rin it looks like we've merged this with master, right? Can we close this one? :)

[mischacolley]

@lulen11 can you preview this visually first and play around with style/settings ... from when I last looked at this I assume it would still need work

[lulen11]

hey @kbardi i reckon this would be your next best component to work on :)

[lulen11]

hey @bronz3beard i know you've been working on this one. is this PR still relevant? What's the status?

[bronz3beard]

hey @bronz3beard i know you've been working on this one. is this PR still relevant? What's the status?

Hey @lulen11
Not sure about this pr, but there is another pr for react-player, AimeVideoPlayer.
It is probably better to ask @rin about this one, if this pr gets closed we can just add a link to my pr as reference.

[rin]

Yeah, we can close that! It was just important that Rory saw it as a reference :). But even if it's closed, we can always find it again.