fix: guard None class docstring in update_class_documentation - #493
Open
Shtirmann wants to merge 1 commit into
Open
fix: guard None class docstring in update_class_documentation#493Shtirmann wants to merge 1 commit into
Shtirmann wants to merge 1 commit into
Conversation
andreygetmanov
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
В проходе обновления по main idea (
incremental=False) ВСЕ классы уходят вupdate_class_documentation- в том числе классы без докстринга. А метод сразу делаетclass_details[-1].split("\n\n", ...), и вexcept-фолбэке -class_details[-1].strip(). Когда у класса нет докстринга,class_details[-1]этоNone, и обе строки падают сAttributeError: 'NoneType' has no attribute 'split'/'strip'.Падает не тихо: исключение рушит весь batch обновления классов через
asyncio.gather, иDocstringsGenerator.run()возвращает{"result": None}- хотя докстринги функций/методов к этому моменту уже записаны.Воспроизводится на реальном репо
sindresorhus/yocto-queue: классыNode/Queueбез докстрингов -> краш в update-проходе ->run()->None.Поправил.