Repository navigation
Test l05 lab hw - #243
Closed
Sotvorenniy wants to merge 15 commits into
Closed
Test l05 lab hw#243Sotvorenniy wants to merge 15 commits into
Sotvorenniy wants to merge 15 commits into
Conversation
…LOG_LEVEL
Two boot blockers when running ./scripts/dev.sh from a clean checkout:
1. The API imports reviewer-core's raw source via the tsconfig path alias, so
Node resolves `openai` relative to reviewer-core/src — but dev.sh only
installed deps for server and client, never reviewer-core, so boot crashed
with ERR_MODULE_NOT_FOUND ('openai'). e2e.sh already handled this; dev.sh
now does the same (npm ci in reviewer-core when node_modules is missing).
openai is a real runtime dep (OpenRouter SDK + zod→json-schema helper used
by both the OpenAI and Anthropic paths), so removing it was not an option.
2. With openai resolving, the next crash was env validation: .env ships
`LOG_LEVEL=` empty, and z.enum(...).optional() rejects '' (it permits
undefined, not an empty string). Coerce '' → undefined so it falls through
to the 'info' default; also unblocks any .env files already on disk.
Verified: pnpm dev now reaches a healthy /health.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* L01-lab: lab work based on first video from L01 * L01-lab-hw: homework * L01-lab-hw: homework after review
* L02-lab-hw: lab part 1, adding AGENTS.md * L02-lab-hw: lab part 1, step 1: added onion-architecture, frontend-ui-architecture, pr-self-review + refactoring * L02-lab-hw: lab step 2 * L02-lab-hw: lab hw + skill page fix * L02-lab-hw: lab hw + skill page fix + agents fix
* L03-lab-hw: lab * L03-lab-hw: lab: ui fix * L03-lab-hw: lab: fix * L03-lab-hw: homework L03 * L03-lab-hw: homework L03: minor fixes * L03-lab-hw: homework L03: fixes after feedback
* L04-lab-hw: lab video 1 * L04-lab-hw: lab video 3: added settings and pnpm * L04-lab-hw: hw * L04-lab-hw: test pr hw 4 fixes
Spec-creator output for the Onboarding Generator: five-section tour (architecture, critical paths, run locally, reading path, first tasks), deterministic repo-intel facts, one structured LLM call, skeleton fallback, onboarding.generated cost log. 16 EARS ACs, approved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Implementation-planner output (3 phases, every step cites AC1-AC16), revised after a cross-model review (Sonnet). Spec rev 1 clarifies AC9 skeleton reasons (empty ranked set, over-budget prompt, infra errors) and section counts as grounding targets. Plan is force-added because .claude/plans/ is git-ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Brief card on the Overview tab: summary, Risk areas and Review focus generated by one structured model call over precomputed facts (intent, blast radius, diff stats + hunk headers, PR body, linked issue, attached specs), grounded against the PR diff and blast callers, cached in pr_brief with the head SHA. Review focus items deep-link to Files changed at the file and line. - server: brief module (GET cache-only, POST generate), single-shot LLM, input caps and prompt budget, seeded brief for PR #482, head SHA persisted on PR detail refresh - client: PrBriefCard, hooks, i18n, Overview layout, diff focus scroll-once, optional verdict banner and risk expand - tests: server unit/wiring/IT, client, e2e flow 09 - docs: docs/pr-brief.md; INSIGHTS entries Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iter rules) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.