Optimize JsonCompleter.parse string scanning#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize
JsonCompleter.parsefor long streamed string values.The hot path was
Scanners.scan_string. It used to walk ordinary string content one character at a time, even when the next few hundred bytes were just plain text. This change makes it jump to the next interesting character (",\\, or a control character) and copy the whole plain run in one slice.That keeps the existing parsing behavior, escape handling, and unicode/surrogate validation, but does a lot less Ruby work on the common case.
Before / after
Benchmark command:
JSON_COMPLETER_BENCHMARK=1 bundle exec rspec spec/parse_benchmark_spec.rbBenchmark settings from the spec run:
776909712508parse1.9350s1.2476s35.5% faster38.700ms24.952ms35.5% faster4,381,5882,047,56953.3% fewerRelative to
complete + JSON.parse9.07x12.98x4.66x8.83xWhat changed
README.mdWhy this helps
Most streamed JSON text is boring: long runs of normal characters with only occasional escapes or quotes.
Before:
After:
Same result, less interpreter overhead, fewer temporary objects.
Validation
bundle exec rubocopbundle exec rspecJSON_COMPLETER_BENCHMARK=1 bundle exec rspec spec/parse_benchmark_spec.rb