Register the two flat native-mode rooms - #41
Merged
Merged
Conversation
llm_subscriptions and environments carry native-mode invalidations to the LLM Proxy. Unregistered they fell to the default deny, which is the policy that branch exists to enforce -- a room kind added later has to state its policy rather than inherit an accidental allow. This states it. Same shape as egress_rules and for the same reason: the proxy caches a binding on a connection and cannot enumerate the organizations or environments it will serve, so a per-organization room would leave it re-subscribing forever or missing invalidations for one it has not seen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llm_subscriptions and environments carry native-mode invalidations to the LLM Proxy. Unregistered they fell to the default deny, which is the policy that branch exists to enforce — a room kind added later has to state its policy rather than inherit an accidental allow.
Same shape as egress_rules and for the same reason: the proxy caches a binding on a connection and cannot enumerate the organizations or environments it will serve, so a per-organization room would leave it re-subscribing forever or missing invalidations for one it has not seen.
Also repairs devspace.yaml, which could not be loaded at all: a pipeline and command named test:e2e fail DevSpace's naming rule, and the dev patch left the chart's probes in place, so the container was killed a minute in while waiting for its source.
Part of native LLM mode.