Recognise the agent_instance room - #38
Merged
Merged
Conversation
agents publishes instance.updated to agent_instance:<id> and the Orchestrator subscribes to it for every instance it reconciles, but the room was never added here. It fell through to the deny-by-default branch, so every one of those subscriptions was refused and a paused, resumed or terminated instance reached nobody. Gated like the agent room it mirrors: member on the owning organization. That also admits the instance itself, whose identity satisfies member through its own org relation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents publishes
instance.updatedtoagent_instance:<id>and the Orchestrator subscribes to it for every instance it reconciles — but the room was never added torooms.go. It fell through to the deny-by-default branch, so every one of those subscriptions was refused: a paused, resumed or terminated instance reached nobody.Gated like the
agent:{id}room it mirrors —memberon the owning organization. That also admits the instance itself, whose identity satisfiesmemberthrough its ownorgrelation (authz.md). Spec table updated in a matching architecture commit.