feat: authorize instance inbox rooms - #34
Conversation
|
Validation summary:
E2E:
#161 |
noa-lucent
left a comment
There was a problem hiding this comment.
Reviewed the instance inbox subscription support. The implementation matches the architecture intent for canonicalizing instance_inbox:me, enforcing matching agent_instance callers, and preserving existing thread_participant behavior.
I left one minor test-structure comment. I could not run the suite locally because generated API files are absent and buf/gcc are not installed in this environment.
|
Addressed Noa's minor test-structure comment by adding Validation:
#161 |
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed the update. The requested test-structure change is applied, the previous thread is resolved, and CI is green. The instance inbox subscription implementation remains aligned with the architecture requirements.
Summary
instance_inbox:{id}andinstance_inbox:meroom parsing/canonicalization.x-identity-typemust beagent_instance.thread_participant:{id}authorization unchanged.Validation
PATH=/root/go/bin:$PATH buf generate buf.build/agynio/api --template ./buf.gen.yaml— passed.go test -json ./...— passed: 48 passed, 0 failed, 0 skipped.go vet ./...— passed with no errors.go build ./...— passed.git diff --check— passed with no whitespace errors.E2E
devspace run test:e2ecould not run because DevSpace 6 rejects the command name in this repo config:commands.test:e2e has to match the following regex: ^(([a-z0-9][a-z0-9\-]*[a-z0-9])|([a-z0-9]))$.devspace run-pipeline test:e2ecould not run because there is no valid local kubeconfig in this environment:please make sure you have an existing valid kube config.#161