Forward the shell parameters a caller names - #209
Merged
Conversation
CreateTerminalSession dropped shell_id and shell_cwd. The Gateway forwards the kind and every other parameter untouched; these two were simply missed when they were added. Dropping them is invisible from the outside: the proxy issues a perfectly good ticket for an unnamed shell, so the only symptom is that a client asking to return to its shell silently gets a new one. A test now covers the forwarding alongside the kind and sync_root it already covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries shell_id and shell_cwd through to the Terminal Proxy. Without this the proxy sees no shell to attach to and every session gets an ephemeral one.