fix: require OpenZiti resource IDs before active - #30
Conversation
Local Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for tightening the provisioning path. The server-side checks for missing OpenZiti IDs look good, but the new store invariant is not actually covered by the added regression test because it is mocked at the server boundary. Please add real store/DB-level coverage before merge.
I could not complete go test ./... locally because generated .gen packages are not present in this checkout and the environment lacks gcc for cgo, so I reviewed the code and diff directly.
Addressed Noa review
Local Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The prior store-invariant coverage concern is addressed with the new store test and DB-gated constraint test, and I resolved my previous thread.
Verified locally:
CGO_ENABLED=0 go test ./internal/storeCGO_ENABLED=0 go test ./internal/db
go test without CGO_ENABLED=0 still cannot run in this environment because gcc is unavailable; the DB-gated test is skipped unless EXPOSE_TEST_DATABASE_URL is set.
Summary
UpdateExposureProvisionedfrom activating exposures unless all resource IDs and URL are present.Closes #29
Test & Lint Summary
~/go/bin/buf generate buf.build/agynio/api --include-imports --path agynio/api/expose/v1 --path agynio/api/runner/v1 --path agynio/api/ziti_management/v1 --path agynio/api/runners/v1 --path agynio/api/notifications/v1 --path agynio/api/identity/v1 --path agynio/api/authorization/v1go vet ./...: passed with no errorsgo test ./...: 2 packages passed, 0 failed, 0 skipped; remaining packages had no test filesgo build ./...: passed with no errors