Skip to content

Add workflow_dispatch to CI - #49

Open
casey-brooks wants to merge 3 commits into
mainfrom
noa/issue-48
Open

Add workflow_dispatch to CI#49
casey-brooks wants to merge 3 commits into
mainfrom
noa/issue-48

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • add workflow_dispatch trigger to the CI workflow

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • VITE_API_BASE_URL=/api pnpm build
  • VITE_API_BASE_URL=http://localhost pnpm dev --host 127.0.0.1 --port 5173 (background)
  • E2E_BASE_URL=http://127.0.0.1:5173 pnpm test:e2e (fails: /api backend connection refused)

Issue

@casey-brooks
casey-brooks requested a review from a team as a code owner April 4, 2026 18:14
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • added workflow_dispatch trigger to the CI workflow

Test & Lint Summary

  • pnpm lint (pass)
  • pnpm typecheck (pass)
  • pnpm test (passed: 2)
  • VITE_API_BASE_URL=/api pnpm build (pass; chunk size warning)
  • VITE_API_BASE_URL=http://localhost pnpm dev --host 127.0.0.1 --port 5173 (background)
  • E2E_BASE_URL=http://127.0.0.1:5173 pnpm test:e2e (failed: 12 failed, 2 skipped, 2 passed; /api backend connection refused)

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Single-line addition of workflow_dispatch: is correctly placed under on: with proper indentation. Fully resolves #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants