Persistence is the environment's field, not a session kind - #192
Merged
Conversation
SHELL_ATTACH is removed and its number reserved. Whether a shell outlives its connection is not something a caller asks for: SHELL takes shell_id and shell_cwd, and the workload decides whether the shell they name survives. Environment gains persistent_shells, defaulting to true. Create and Update take it as optional so an unset field means "leave it alone" rather than "off". Workload gains persistent_shells, resolved from the environment at start. The Terminal Proxy reads it from a call it already makes; nothing else needs to resolve an environment to answer the question.
Reserving a deleted enum value does not satisfy the breaking check, and it should not: a client still sending SHELL_ATTACH mid-rollout deserves a working shell rather than an InvalidArgument. The value stays, marked deprecated, and the proxy treats it as SHELL -- which now means the same thing, since the workload decides whether the shell persists.
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment.persistent_shells, and the field on the create and update requests.RunnerEnvironment.persistent_shellsandpersistent_shellson the runner session message.SHELL_ATTACHretained as a deprecated alias.console-app/#147 does not build until this is on the BSR.