You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implemented subscriber stream log context for Subscribe/Recv/rooms refresh phases with service target addresses, room snapshot counts/samples/fingerprints, gRPC code/description, and retry backoff.
Added suppression for repeated identical subscriber stream errors while keeping the first occurrence visible and emitting periodic summaries with suppressed counts.
Improved closely related runner dial and Ziti manager retry/error logs with actionable service/identity/backoff/auth context.
Added unit coverage for snapshot formatting and repeated-error limiter behavior.
Test & Lint Summary
go test -json ./... | tee /tmp/agents-orchestrator-test.json >/dev/null: 151 passed / 0 failed / 0 skipped.
Requesting review.\n\nFix for #205: subscriber logs now include operation phase + target address + room snapshot fingerprint/counts/sample + grpc code/desc + backoff, with suppression/summary for repeated identical stream errors (including the "Unauthenticated: identity not available" case). Also improved a few closely related low-context logs and added unit tests.
The reason will be displayed to describe this comment to others. Learn more.
Review complete. The subscriber stream logs now include the required phase, service target, room counts/sample/fingerprint, gRPC code/description, and backoff context; repeated identical stream errors are rate-limited with summary logging. The closely related runner/Ziti retry logs also have clearer context, and the new formatting/rate-limit helpers have unit coverage.\n\nI attempted to run go test ./... locally, but this checkout cannot resolve generated .gen packages and the environment lacks gcc for cgo, so local verification could not complete here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #205
Test & Lint Summary
go test -json ./... | tee /tmp/agents-orchestrator-test.json >/dev/null: 151 passed / 0 failed / 0 skipped.go test ./...: passed.go build ./...: passed.go vet ./...: passed with no errors.