Skip to content

Improve subscriber stream error logging - #206

Open
casey-brooks wants to merge 1 commit into
mainfrom
noa/issue-205
Open

Improve subscriber stream error logging#206
casey-brooks wants to merge 1 commit into
mainfrom
noa/issue-205

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Adds subscriber stream log context for Subscribe/Recv/rooms refresh phases, service target addresses, room snapshot counts/samples/fingerprints, gRPC code/description, and retry backoff.
  • Suppresses repeated identical subscriber stream errors while logging the first full occurrence and periodic summaries with suppressed counts.
  • Improves closely related runnerdial and zitimanager retry/error logs with service/identity/backoff/auth context.
  • Adds unit coverage for room snapshot formatting and repeated stream error suppression.

Closes #205

Test & Lint Summary

  • go test -json ./... | tee /tmp/agents-orchestrator-test.json >/dev/null: 151 passed / 0 failed / 0 skipped.
  • go test ./...: passed.
  • go build ./...: passed.
  • go vet ./...: passed with no errors.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • go test -json ./... | tee /tmp/agents-orchestrator-test.json >/dev/null: 151 passed / 0 failed / 0 skipped.
  • go test ./...: passed.
  • go build ./...: passed.
  • go vet ./...: passed with no errors.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Completion Summary

  • Implemented subscriber stream log context for Subscribe/Recv/rooms refresh phases with service target addresses, room snapshot counts/samples/fingerprints, gRPC code/description, and retry backoff.
  • Added suppression for repeated identical subscriber stream errors while keeping the first occurrence visible and emitting periodic summaries with suppressed counts.
  • Improved closely related runner dial and Ziti manager retry/error logs with actionable service/identity/backoff/auth context.
  • Added unit coverage for snapshot formatting and repeated-error limiter behavior.

Test & Lint Summary

  • go test -json ./... | tee /tmp/agents-orchestrator-test.json >/dev/null: 151 passed / 0 failed / 0 skipped.
  • go test ./...: passed.
  • go build ./...: passed.
  • go vet ./...: passed with no errors.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Validation Update

Test & Lint Summary

  • go test -json ./... | tee /tmp/agents-orchestrator-test.json >/dev/null: 151 passed / 0 failed / 0 skipped.
  • go test ./...: passed.
  • go build ./...: passed.
  • go vet ./...: passed with no errors.

@rowan-stein

Copy link
Copy Markdown
Collaborator

Requesting review.\n\nFix for #205: subscriber logs now include operation phase + target address + room snapshot fingerprint/counts/sample + grpc code/desc + backoff, with suppression/summary for repeated identical stream errors (including the "Unauthenticated: identity not available" case). Also improved a few closely related low-context logs and added unit tests.

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. The subscriber stream logs now include the required phase, service target, room counts/sample/fingerprint, gRPC code/description, and backoff context; repeated identical stream errors are rate-limited with summary logging. The closely related runner/Ziti retry logs also have clearer context, and the new formatting/rate-limit helpers have unit coverage.\n\nI attempted to run go test ./... locally, but this checkout cannot resolve generated .gen packages and the environment lacks gcc for cgo, so local verification could not complete here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve subscriber stream error logs with identity/service/agent context (Unauthenticated: identity not available)

3 participants