Skip to content

Fix DevSpace source sync readiness race - #188

Open
casey-brooks wants to merge 1 commit into
mainfrom
noa/issue-186
Open

Fix DevSpace source sync readiness race#188
casey-brooks wants to merge 1 commit into
mainfrom
noa/issue-186

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Wait for all required source/config files in /opt/app/data before running buf generate.
  • Match the runners DevSpace convention by checking go.mod, go.sum, buf.gen.yaml, buf.yaml, and cmd/orchestrator/main.go.
  • Add explicit sync/generation log messages to make source deploy startup diagnostics clearer.

Fixes #186

Test & Lint Summary

  • buf generate buf.build/agynio/api --include-imports --path agynio/api/runner/v1 --path agynio/api/runners/v1 --path agynio/api/threads/v1 --path agynio/api/notifications/v1 --path agynio/api/metering/v1 --path agynio/api/agents/v1 --path agynio/api/secrets/v1 --path agynio/api/ziti_management/v1 --path agynio/api/identity/v1 --path agynio/api/llm/v1 --path agynio/api/users/v1 --path agynio/api/organizations/v1 --path agynio/api/tracing/v1: passed
  • go test -json ./...: 149 passed, 0 failed, 0 skipped
  • go build ./...: passed
  • git diff --check: passed with no whitespace/lint errors
  • devspace print --skip-info: passed

Note: I could not execute the full .github/workflows/e2e.yml locally because it depends on GitHub Actions provisioning actions and a Kubernetes cluster, but the DevSpace config now renders locally and the workflow should run on this PR.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --include-imports --path agynio/api/runner/v1 --path agynio/api/runners/v1 --path agynio/api/threads/v1 --path agynio/api/notifications/v1 --path agynio/api/metering/v1 --path agynio/api/agents/v1 --path agynio/api/secrets/v1 --path agynio/api/ziti_management/v1 --path agynio/api/identity/v1 --path agynio/api/llm/v1 --path agynio/api/users/v1 --path agynio/api/organizations/v1 --path agynio/api/tracing/v1: passed
  • go test -json ./...: 149 passed, 0 failed, 0 skipped
  • go build ./...: passed
  • git diff --check: passed with no whitespace/lint errors
  • devspace print --skip-info: passed

Note: I could not execute the full .github/workflows/e2e.yml locally because it depends on GitHub Actions provisioning actions and a Kubernetes cluster, but the DevSpace config renders locally and the workflow should run on this PR.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

CI E2E Update

The PR E2E / e2e workflow progressed past the issue-specific source deploy failure:

  • Deploy orchestrator from source: passed
  • CI / build: passed

The remaining Run E2E tests failure is outside the DevSpace readiness race addressed here. It fails in downstream e2e suites with gateway authorization/test-data errors, for example:

  • CreateLLMProvider failed with status 403: {"code":"permission_denied","message":"permission denied"}
  • CreateAgent failed (400): {"code":"invalid_argument","message":"availability: must be internal or private"}

These are not CrashLoopBackOff or missing buf.gen.yaml failures; the patched orchestrator source deployment successfully becomes ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E failing: Deploy orchestrator from source crashloops (missing buf.gen.yaml)

1 participant