test(e2e): exercise expose lifecycle - #139
Conversation
|
Summary:
Tests/Lint:
Test stats: passed 7, failed 0, skipped 5. CI:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-structured E2E test that covers the full expose lifecycle as specified in #138. Assertions are actionable (stdout/stderr included on failure), JSON output is properly parsed, and all five acceptance criteria are addressed.
Two minor suggestions left inline — consolidating the duplicate init image default and updating the test name to reflect the broader scope.
| orgsClient := organizationsv1.NewOrganizationsServiceClient(orgsConn) | ||
| runnerClient := runnerv1.NewRunnerServiceClient(runnerConn) | ||
| exposeInitImage := envOrDefault("AGN_EXPOSE_INIT_IMAGE", "ghcr.io/agynio/agent-init-agn:0.3.5") | ||
| exposeInitImage := envOrDefault("AGN_EXPOSE_INIT_IMAGE", "ghcr.io/agynio/agent-init-agn:0.4.4") |
There was a problem hiding this comment.
[minor] This local exposeInitImage duplicates the package-level agnInitImage from main_test.go (same image, same tag 0.4.4). Having the default hardcoded in two places means they can drift silently when one is bumped but not the other — as happened before this PR (0.3.5 here vs 0.4.1 in main_test.go).
Consider reusing the package-level agnInitImage directly, unless there's an intentional reason to pin the expose test to a different image.
| Status string `json:"status"` | ||
| } | ||
|
|
||
| func TestAgentExposeListExec(t *testing.T) { |
There was a problem hiding this comment.
[nit] The function name TestAgentExposeListExec was accurate when the test only verified expose list, but now it covers the full add → list → duplicate → remove → list lifecycle. Consider renaming to something like TestAgentExposeLifecycle to reflect the broader scope.
|
Note: E2E failure ( Bootstrap PR (ready to merge): agynio/bootstrap#337 |
Summary
Testing
|
Summary
Testing
Ref #138