Skip to content

docs(m109-001): changelog — CLI logs/credential fixes + approval durability#120

Open
indykish wants to merge 1 commit into
mainfrom
chore/m109-001-changelog
Open

docs(m109-001): changelog — CLI logs/credential fixes + approval durability#120
indykish wants to merge 1 commit into
mainfrom
chore/m109-001-changelog

Conversation

@indykish

@indykish indykish commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Changelog entry for the user-visible fixes in agentsfleet#473:

  • agentsfleet fleet logs no longer crashes on a malformed timestamp
  • agentsfleet workspace credentials names the real agentsfleet credential group
  • Approval enforcement survives a failed Redis mirror write via a database fallback

🤖 Generated with Claude Code

Greptile Summary

This PR adds a changelog entry documenting three user-visible fixes from agentsfleet#473: a RangeError crash in agentsfleet fleet logs on malformed timestamps, a broken redirect in agentsfleet workspace credentials, and an approval-enforcement fallback when Redis mirror writes fail.

  • Duplicate heading: The new <Update> block has ## Reliability fixes for logs, credential help, and approval enforcement immediately followed by ## Fixes with no prose between them — the redundant sub-heading can be removed.
  • Content accuracy: The three fix descriptions match the PR description and are clearly worded for end users.

Confidence Score: 4/5

Safe to merge — documentation-only change with one minor structural issue in the new entry's heading layout.

The change is a single changelog entry describing already-shipped fixes. The only issue found is a redundant ## Fixes sub-heading sitting immediately beneath the title heading with no prose between them, producing two consecutive <h2> elements — visually awkward but harmless to functionality.

No files require special attention beyond the double-heading nit in the new <Update> block in changelog.mdx.

Important Files Changed

Filename Overview
changelog.mdx Adds a new <Update> block documenting three CLI/reliability fixes; contains a redundant duplicate ## Fixes heading immediately after the section title with no prose between them.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["agentsfleet fleet logs"] -->|malformed timestamp| B{"RangeError?"}
    B -->|Before fix| C["❌ Command crashes / aborts"]
    B -->|After fix| D["✅ Renders '—', stream continues"]

    E["agentsfleet workspace credentials"] -->|redirect| F{"Target command group"}
    F -->|Before fix| G["❌ agentsfleet agent credential (non-existent)"]
    F -->|After fix| H["✅ agentsfleet credential (real group)"]

    I["Approval enforcement (lease path)"] --> J{"Redis mirror write"}
    J -->|Success| K["✅ Grant honored via Redis"]
    J -->|Failure| L{"Fallback?"}
    L -->|Before fix| M["❌ Enforcement diverges from audit trail"]
    L -->|After fix| N["✅ Durable DB row consulted as fallback"]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["agentsfleet fleet logs"] -->|malformed timestamp| B{"RangeError?"}
    B -->|Before fix| C["❌ Command crashes / aborts"]
    B -->|After fix| D["✅ Renders '—', stream continues"]

    E["agentsfleet workspace credentials"] -->|redirect| F{"Target command group"}
    F -->|Before fix| G["❌ agentsfleet agent credential (non-existent)"]
    F -->|After fix| H["✅ agentsfleet credential (real group)"]

    I["Approval enforcement (lease path)"] --> J{"Redis mirror write"}
    J -->|Success| K["✅ Grant honored via Redis"]
    J -->|Failure| L{"Fallback?"}
    L -->|Before fix| M["❌ Enforcement diverges from audit trail"]
    L -->|After fix| N["✅ Durable DB row consulted as fallback"]
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
changelog.mdx:25-30
The entry opens with a descriptive title heading (`## Reliability fixes…`) and then immediately places a second bare `## Fixes` heading with no prose between them. This renders two consecutive `<h2>` elements with nothing in between, which is visually awkward and inconsistent with other entries in the file — for example, the `Jul 03, 2026` UI entry opens with its title heading, adds a prose paragraph, and then introduces `## What's new`. The `## Fixes` sub-heading is redundant given the title already names the theme.

```suggestion
<Update label="Jul 03, 2026" tags={["Fixes", "CLI"]}>
  ## Reliability fixes for logs, credential help, and approval enforcement

  - **`agentsfleet fleet logs`** — a malformed event timestamp no longer throws `RangeError` and aborts the command; that row renders `—` and the log stream continues.
```

Reviews (1): Last reviewed commit: "docs(m109-001): changelog — CLI logs/cre..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

…bility

User-visible fixes from PR agentsfleet#473: `agentsfleet fleet logs` no longer
crashes on a malformed timestamp, `agentsfleet workspace credentials` names the
real `agentsfleet credential` group, and an approved/denied grant survives a
failed Redis mirror write via a database fallback.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mintlify

mintlify Bot commented Jul 3, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
agentsfleet 🟢 Ready View Preview Jul 3, 2026, 9:48 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Comment thread changelog.mdx
Comment on lines +25 to +30
<Update label="Jul 03, 2026" tags={["Fixes", "CLI"]}>
## Reliability fixes for logs, credential help, and approval enforcement

## Fixes

- **`agentsfleet fleet logs`** — a malformed event timestamp no longer throws `RangeError` and aborts the command; that row renders `—` and the log stream continues.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The entry opens with a descriptive title heading (## Reliability fixes…) and then immediately places a second bare ## Fixes heading with no prose between them. This renders two consecutive <h2> elements with nothing in between, which is visually awkward and inconsistent with other entries in the file — for example, the Jul 03, 2026 UI entry opens with its title heading, adds a prose paragraph, and then introduces ## What's new. The ## Fixes sub-heading is redundant given the title already names the theme.

Suggested change
<Update label="Jul 03, 2026" tags={["Fixes", "CLI"]}>
## Reliability fixes for logs, credential help, and approval enforcement
## Fixes
- **`agentsfleet fleet logs`** — a malformed event timestamp no longer throws `RangeError` and aborts the command; that row renders `` and the log stream continues.
<Update label="Jul 03, 2026" tags={["Fixes", "CLI"]}>
## Reliability fixes for logs, credential help, and approval enforcement
- **`agentsfleet fleet logs`** — a malformed event timestamp no longer throws `RangeError` and aborts the command; that row renders `` and the log stream continues.
Prompt To Fix With AI
This is a comment left during a code review.
Path: changelog.mdx
Line: 25-30

Comment:
The entry opens with a descriptive title heading (`## Reliability fixes…`) and then immediately places a second bare `## Fixes` heading with no prose between them. This renders two consecutive `<h2>` elements with nothing in between, which is visually awkward and inconsistent with other entries in the file — for example, the `Jul 03, 2026` UI entry opens with its title heading, adds a prose paragraph, and then introduces `## What's new`. The `## Fixes` sub-heading is redundant given the title already names the theme.

```suggestion
<Update label="Jul 03, 2026" tags={["Fixes", "CLI"]}>
  ## Reliability fixes for logs, credential help, and approval enforcement

  - **`agentsfleet fleet logs`** — a malformed event timestamp no longer throws `RangeError` and aborts the command; that row renders `—` and the log stream continues.
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant