chore: remove dead style vars and unused listItem.display#9
Merged
Conversation
Eight lipgloss style vars (normalStyle, dimStyle, projectStyle, headerStyle, userStyle, assistantStyle, borderStyle, helpStyle) were never referenced - the UI is rendered with raw ANSI escapes, and only selectedStyle is used. Go doesn't flag unused package-level vars, so they rotted silently and presented a second, fake styling system to the next reader. Likewise listItem.display was never written or read. Deletes both. selectedStyle and the lipgloss import stay (still used).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Maintainability finding from the codebase review (Leia + Yoda lenses, compiler-confirmed).
normalStyle,dimStyle,projectStyle,headerStyle,userStyle,assistantStyle,borderStyle,helpStylewere each referenced only at their own declaration. The UI is actually rendered with raw ANSI escapes (\033[…m); onlyselectedStyleis used. Go doesn't flag unused package-level vars, so they rotted silently and presented a second, fake styling subsystem - a maintainer "fixing a colour" by editing one would see no effect.listItem.display- declared with a misleading comment ("What to show in the list") but never written or read.Deletes both.
selectedStyleand thelipglossimport stay (still used byselectedStyleand inlinelipgloss.NewStyle()calls inView).Pure deletion, no behaviour change:
go build,go vet, and the full test suite pass. 40 lines lighter.