chore: refresh README and harden release workflow#7
Merged
Conversation
README had drifted from the binary's --help: - document the --exclude flag (default observer-sessions) - fix the from-source Go requirement (1.21 -> 1.24, matching go.mod) - mention the session-name feature in the list CI: - add concurrency to the release job so back-to-back merges to main don't run two releases at once (racing the tag bump and the GoReleaser/Homebrew-tap publish); cancel-in-progress is false so a publish is never killed mid-flight - bump setup-go 1.21 -> 1.24 in both workflows to match go.mod, instead of relying on the 1.21 toolchain silently auto-downloading 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README
Drifted from the binary's
--help:--exclude- it's parsed (defaultobserver-sessions) and in--help, but was missing from the flags table.go.moddeclaresgo 1.24.0. Someone on 1.21 would fail to build.CI
ci.yamlruns test → auto-tag → GoReleaser on every push tomain, with noconcurrencyguard. Back-to-back merges (exactly what just happened with feat: show session name in search results #3/fix: render multibyte text without corrupting UTF-8 #4/perf: lowercase search text once instead of every keystroke #5) can run two releases at once, racing the tag bump and the GoReleaser / Homebrew-tap publish. Added aconcurrencyblock on thereleasejob withcancel-in-progress: falseso a publish is never killed mid-flight - the next one queues behind it.setup-go1.21 → 1.24 in bothci.yamlandtest.yamlto matchgo.mod. CI passed before only because the 1.21 toolchain silently auto-downloads 1.24; the pin was stale and misleading.No code changes.