Repository navigation
feat(acp): update schema to 1.12.0 and align v2 lifecycle - #423
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unstable_session_system_prompt, include it in theunstableaggregate, and document capability-gated system prompts through the existing complete-request session helpers.requires_actionand ending withoutrunningin the one-shot client and cookbook.Validation
just test: 895 passed, 45 ignored, including workspace binaries/examples and doctests.cargo check -p agent-client-protocol --no-default-features --features unstable_session_system_prompt --lockedcargo check -p agent-client-protocol --no-default-features --features unstable_protocol_v2,unstable_session_system_prompt --lockedcargo fmt --all -- --checkmdbook build(after installing the ignored Mermaid assets)v2_one_shot_clientagainstsimple_agent_v2over stdio; insertion, output, idle completion, and close succeeded.Notes
The initial full test run hit
acp_agent::tests::protocol_eof_still_reports_nonzero_child_exit; it passed on subsequent full runs. No unrelated child-process behavior changes are included. SDK package versions remain managed by the release workflow.