Repository navigation
chore(deps): upgrade hmac and sha2 together - #422
Merged
Merged
Conversation
benbrandt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #420 and #421 with a coordinated dependency upgrade. Both individual updates fail because
Hmac<Sha256>combines incompatible versions of the RustCryptodigesttraits when only one dependency is upgraded.hmacfrom 0.12.1 to 0.13.0 andsha2from 0.10.9 to 0.11.1 (the latest compatible patch release), so both usedigest0.11.hmac::KeyInit, which is required fornew_from_slicewith the new API.Validation
All local checks passed on macOS:
just test(workspace builds, tests, and doctests, including existing HTTP authentication coverage)CARGO_TARGET_DIR=target/msrv cargo +1.88.0 check --workspace --all-targets --all-features --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo fmt -- --checkgit diff --checkThe Linux feature-powerset and WASM/WASI checks are left to CI.