Skip to content

fix: forward native asynchronous user questions - #618

Closed
terrbear wants to merge 1 commit into
agentclientprotocol:mainfrom
terrbear:fix/async-user-input
Closed

terrbear wants to merge 1 commit into
agentclientprotocol:mainfrom
terrbear:fix/async-user-input

Conversation

@terrbear

@terrbear terrbear commented Oct 12, 2026 •

Copy link
Copy Markdown

Native request_user_input_async emits agentMessage.questions, sometimes with empty text. The adapter discarded this field, so the tool reported success while ACP clients received no question.

Forward completed question items and history replay as visible text with structured _meta["codex/asyncUserInput"] = {id, questions}. Clients can render persistent forms and send the answer as a subsequent user prompt. Document the extension and cover textless live events, history, and free-text questions.

Validation: typecheck and production bundle pass; 11 event/history tests pass; an isolated real Codex run emitted the structured question event with the requested choices. Companion AHP consumption and answer routing are covered in terrbear/ahpd#20.

Full bridge suite: 1,490 tests passed and 36 skipped. One deep-JSON stack-limit test fails on Node 22.14.0 identically against unchanged upstream code. The patched runtime was deployed with ahpd PR 20; an isolated production Anton session received a question, retained it after completion, saved a synthetic Blue answer, and returned “Blue selected for the transport test.”

@terrbear terrbear closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant