Repository navigation
fix: display the selected wire provider as JetBrains Air Gateway - #589
Merged
EugeneTheDev merged 1 commit intoOct 13, 2026
Merged
EugeneTheDev merged 1 commit into
EugeneTheDev merged 1 commit into
Conversation
EugeneTheDev
approved these changes
Oct 13, 2026
| }; | ||
| } | ||
|
|
||
| export function agentConfiguredProviderStatus(providerId: string | null): AuthStatus { |
Collaborator
There was a problem hiding this comment.
This is the only place in the code that explains why a provider ID of wire is shown with JetBrains branding, and right now it explains nothing. Could we pull "wire" and the label into named constants next to DEFAULT_GATEWAY_LABEL, and add a short doc comment like the ones on the neighbouring functions? It should say this is a display-only heuristic on the agent-owned provider ID (see docs/air-extensions.md). Otherwise the next reader has to guess whether matching the bare ID is deliberate.
|
|
||
| export function agentConfiguredProviderStatus(providerId: string | null): AuthStatus { | ||
| if (providerId?.trim().toLowerCase() === "wire") { | ||
| return {kind: "gateway", label: "JetBrains Air Gateway"}; |
Collaborator
There was a problem hiding this comment.
This string is shown to users, and elsewhere (docs, commit history) the product is written AIR, not Air. Was JetBrains Air Gateway checked with the client/product side?
Co-authored-by: Junie <junie@jetbrains.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
serjic
force-pushed
the
serjic/ijai-2956-central-auth-source
branch
from
October 13, 2026 10:29
db5b9d1 to
4fdeb6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses IJAI-2956.
getAgentConfiguredModelProvider()as a gateway when it equalswireafter trimming, case-insensitively.kind: gatewayand the exact labelJetBrains Air Gateway, with nodetailor invented account identity. Do not fetch or inspect the provider's friendlyname, URL, backend, or route.providers/set; an unused wire provider does not affect auth status.docs/air-extensions.md.This is an agreed weak display heuristic, not proof that the endpoint is a Central deployment or that the user has any particular entitlement. A different selected provider ID does not match merely because its friendly name contains
wire.Sanitized auth status
{ "kind": "gateway", "label": "JetBrains Air Gateway" }No keys, headers, private routes, technical
wiredetail, or invented account information is sent.Verification
Based on fresh upstream
mainatca1d971, rechecked immediately before publication. Changes and rebuiltdistare available in the main local clone; the user confirmed the local adapters work.npm run typecheck npm run build npm testScope
No AIR UI, provisioning, personal configuration migration, effort/mode changes, or new ACP protocol. Plan files and personal configurations are not committed.