Update atenet component to use actor *name* instead of *id*.#421
Merged
Haven Xia (HavenXia) merged 1 commit intoJul 10, 2026
Merged
Conversation
Haven Xia (HavenXia)
requested changes
Jul 10, 2026
| // proto request field with structured field-path errors, use | ||
| // ValidateResourceName. Empty is not a valid name. | ||
| func IsValidResourceName(name string) bool { | ||
| return len(content.IsDNS1123Label(name)) == 0 |
Collaborator
There was a problem hiding this comment.
Should we use ResourceNameRegexPattern.MatchString(name) that you refactored in actors.go?
Collaborator
Author
There was a problem hiding this comment.
We used to use the same regexp for validating and for building the DNS configuration, but that changed some time ago when we started using IsDNS1123Label. Considering that ValidateResourceName uses IsDNS1123Label I think we should be consistent.
That being said, it's a bit unfortunate that the validation logic and the regexp don't have a single SoT, but it looks like that's already the case.
Collaborator
|
atenet changes lgtm |
Haven Xia (HavenXia)
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #149. Change
atenetto not mention actor id any longer.