Add benchmarking e2e test#365
Open
Max Smythe (maxsmythe) wants to merge 3 commits into
Open
Conversation
Max Smythe (maxsmythe)
force-pushed
the
e2e-test-benchmarking
branch
from
7b0fb2f to
d69ffc7
Compare
| u.hostHeader = u.actorID + "." + cfg.Atespace + "." + actorDomain | ||
|
|
||
| if err := u.ensureAtespace(ctx); err != nil { | ||
| return fmt.Errorf("EnsureAtespace: %w", err) |
Collaborator
There was a problem hiding this comment.
[minor] When I return an error like this, I usually just do a cut-and-paste "u.ensureAtespace: %w" so that you can just cut and paste the error and do a exact string search.
Also Golang error strings are not supposed to be capitalized in any case
Collaborator
Author
There was a problem hiding this comment.
Good thoughts. Fixed. Left the camel case in, but starting on lower case.
| } | ||
| for _, phase := range []string{"cold", "warm"} { | ||
| if err := u.runIteration(ctx); err != nil { | ||
| return fmt.Errorf("%s iteration: %w", phase, err) |
Collaborator
Author
There was a problem hiding this comment.
fixed
| } | ||
| } | ||
| if err := u.delete(ctx); err != nil { | ||
| return fmt.Errorf("DeleteActor: %w", err) |
Collaborator
Author
There was a problem hiding this comment.
fixed
| return fmt.Errorf("EnsureAtespace: %w", err) | ||
| } | ||
| if err := u.create(ctx); err != nil { | ||
| return fmt.Errorf("CreateActor: %w", err) |
Collaborator
Author
There was a problem hiding this comment.
fixed.
Collaborator
|
lgtm |
Max Smythe (maxsmythe)
force-pushed
the
e2e-test-benchmarking
branch
from
00afcba to
e4698a9
Compare
Collaborator
Author
|
Thanks for the review! Addressed comments and rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a short e2e test to exercise the benchmarking workloads/logic to help ensure changes to Substrate don't quietly break benchmarking.