Repository navigation
fix(tools): keep the tool order when navigation restores the same tools - #1405
Open
zhangt2333 wants to merge 1 commit into
Open
zhangt2333 wants to merge 1 commit into
zhangt2333 wants to merge 1 commit into
Conversation
The re-apply reordered the tools even when pi restored the same loadout, which changed the prompt and re-billed the cached conversation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for pi-web — I've used it for a long time and really like it; this is the first real problem I've run into.
Problem
Editing a history message reorders the same tools:
navigateTreeKeepingToolSelection()re-applies the selection after the navigation restored the branch's loadout, andresolveActiveToolNames()moves every coding tool in front of the carried ones.Nothing was enabled or disabled: only the order changed, which rewrites the system prompt and drops the cached prefix, so the next request re-bills the whole conversation.
Reproduction
1, then2.2, resend as2.2.systementry whose<tools>section carries the order above.