Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-quality.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cache keys still pinned to 2025.3 while the action moves to 2026.2

The Qodana step's cache keys (primary-cache-key/additional-cache-key at .github/workflows/code-quality.yml:38-39) still embed qodana-2025.3, whereas the action is now at 2026.2 (and was already at 2026.1 before this bump). Caches from an older linter version can be restored into the newer runtime; at minimum the key no longer reflects the linter version, so cache invalidation across upgrades stops working. Consider parameterizing the key by the action/linter version when bumping.

(Refers to lines 38-39)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- name: 🔍 Qodana Scan
id: qodana
uses: JetBrains/qodana-action@4861e015da555e86a72b862892aba6c2b93e6891
uses: JetBrains/qodana-action@b588768b6e7e6da579e518bc584f79de0d243692
continue-on-error: true
Comment on lines +30 to 31

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 New action version propagates Qodana exit code, but step is continue-on-error

Release notes for 2026.2.0 include "QD-13746 pass Qodana exit code in action" and a new check that in pr-mode: true the repo is checked out to the source branch. This workflow checks out github.event.pull_request.head.sha (detached HEAD) at .github/workflows/code-quality.yml:24-26, which may trip the new branch check and emit warnings/failures. The step has continue-on-error: true, so job result stays success, but the summary job reads needs.qodana.result (.github/workflows/code-quality.yml:264-270) — worth verifying the new exit-code behavior doesn't change reported results.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

env:
QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
Expand Down
Loading