fix: bound Lark card text fallback outbound waits#2497
Open
jason-aelf wants to merge 4 commits into
Open
Conversation
…-06-30_lark-card-text-fallback
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feature/integrate #2497 +/- ##
=====================================================
+ Coverage 83.74% 83.77% +0.03%
=====================================================
Files 1244 1244
Lines 95469 95512 +43
Branches 12524 12530 +6
=====================================================
+ Hits 79952 80019 +67
+ Misses 9954 9930 -24
Partials 5563 5563
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
我看了一下,这个 PR 方向是在解决正确的问题,但当前实现明显偏重,建议先收敛后再合。 目标可以更简单地表达为:
当前 PR 的主要问题是:
建议改成最小实现: 建议本 PR 收敛为上述普通文本主路径; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Notes