Add workflow chat descriptor set#2383
Conversation
Populate workflow revision artifacts with chat protobuf descriptors so payloadJson requests can be packed for workflow service schedules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7816184e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ProtocolDescriptorSet = BuildProtocolDescriptorSet( | ||
| ChatRequestEvent.Descriptor, | ||
| ChatResponseEvent.Descriptor), |
There was a problem hiding this comment.
Include descriptors in workflow replay hash
When a workflow revision is assembled, ArtifactHash is computed from the full prepared artifact, so this new ProtocolDescriptorSet changes the stored hash. The existing-revision replay path recomputes the expected workflow hash via ScopeBindingCommandApplicationService.BuildWorkflowArtifact, but that mirror artifact still omits the descriptor set; after creating a workflow revision, a retry/upsert with AllowExistingRevisionReplay for the same revision will compare the stored hash including these bytes with an expected hash without them and reject the identical revision as a different artifact.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch. Fixed in 226aebf by moving descriptor-set construction into a shared ServiceProtocolDescriptorSetBuilder and using it from both WorkflowServiceImplementationAdapter and ScopeBindingCommandApplicationService.BuildWorkflowArtifact, so replay hash calculation includes the same ProtocolDescriptorSet bytes as prepared revisions. Also updated scope binding replay tests to compute the descriptor-inclusive workflow artifact hash.
Use a shared descriptor set builder for workflow artifacts so scope binding replay compares the same artifact hash that revision preparation stores. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## feature/integrate #2383 +/- ##
=====================================================
- Coverage 84.08% 83.75% -0.33%
=====================================================
Files 1139 1231 +92
Lines 82320 94468 +12148
Branches 10705 12358 +1653
=====================================================
+ Hits 69219 79125 +9906
- Misses 8414 9857 +1443
- Partials 4687 5486 +799
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 256 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Use a well-known descriptor registry keyed by FileDescriptor name instead of branching on proto dependency strings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-06-26_workflow-descriptor-set
Align the Studio test helper with the current ServiceRunSnapshot shape so coverage-quality can build after rebasing on feature/integrate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
Test plan
dotnet test test/Aevatar.GAgentService.Tests/Aevatar.GAgentService.Tests.csproj --nologo --no-restore --filter ServiceImplementationAdaptersTests -v quietbash tools/ci/test_stability_guards.shpayloadJsonfortype.googleapis.com/aevatar.ai.ChatRequestEvent; schedule creation returned 202 and readback showedscheduleKind: 1.🤖 Generated with Claude Code