[CLIENT-5193] Fix leak when receiving AS_BYTES_PYTHON-type values from the server - #1180
Merged
juliannguyen4 merged 5 commits intoAug 4, 2026
Conversation
…0 and tests the Python client returns that value as a bytearray. TODO - locally I currently see that a bytes instance is returned instead which causes the test to fail
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1180 +/- ##
==========================================
- Coverage 85.39% 85.38% -0.01%
==========================================
Files 101 101
Lines 14614 14615 +1
==========================================
Hits 12479 12479
- Misses 2135 2136 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Local repro with 19.2.2 |
This reverts commit 4ac5524.
…st failure to be resolved
Collaborator
Author
|
Verified locally that the leak no longer appears in valgrind Local build is NOTE - there's some failing jobs because I cancelled them and the status reported as "failing", and the linkcheck job is still flakey |
atripathi-aerospike
approved these changes
Aug 4, 2026
juliannguyen4
deleted the
CLIENT-5193-repro-and-fix-leak-when-recv-AS_BYTES_PYTHON
branch
August 4, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where AS_BYTES_PYTHON are returned as bytes instead of bytearrays
This seems to be affecting customers in production, so I would like to merge this in ASAP
TODO