[CLIENT-4678] Warn if specific fields receives out of bounds constant value (represented as an enumeration in the C client) - #1142
Draft
juliannguyen4 wants to merge 127 commits into
Conversation
… compiler will optimize these switch statements
This reverts commit 80797cb.
…akes it easier to refactor in the future
…rospike_helpers-receives-out-of-bounds-int-without-refactoring
… the latter is a uint32 parameter in the C client instead of an enum
…_ctx_add_from_pyobject and not just for operation dictionaries.
…t of the codebase.
Collaborator
Author
|
…rospike_helpers-receives-out-of-bounds-int-without-refactoring
…rospike_helpers-receives-out-of-bounds-int-without-refactoring
…to handle bit_write_flags, bit resize flags, and bit overflow action.
…rospike_helpers-receives-out-of-bounds-int-without-refactoring
…rospike_helpers-receives-out-of-bounds-int-without-refactoring
…rospike_helpers-receives-out-of-bounds-int-without-refactoring
… a Python value is passed as arg.
…tent with the Python C API. get_int_from_py_dict isn't changed to reduce the scope of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecations
The following API calls will emit a
DeprecationWarningif an out of bounds value is passed for:bit_resizeoperation'sresize_flagsparametermap_createoperation'smap_orderparameterlist_set_orderandlist_createoperations'list_orderparameteris_numeric'snumeric_typeparameterregex_compareandregex_replace'sregex_flagsparameterlist_sortoperation's andListSortexpression'ssort_flagsandorderparameters, respectivelycdt_ctx.cdt_ctx_map_key_create'sorderparametercdt_ctx.cdt_ctx_list_index_create'sorderparameterImproves input validation
Risks
ParamErroris now raised if the user passes a value <INT_MINor >INT_MAXinstead ofINT64_MINandINT64_MAX, respectively. This is not a big deal since these enum values are very well within(INT_MIN, INT_MAX).TODO