fail hermes runs on api errors - #984
Merged
aaronjmars merged 2 commits intoAug 29, 2026
Merged
Conversation
…rs-upstream # Conflicts: # .github/workflows/ci-tests.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
make the hermes adapter fail when the cli prints an http 4xx/5xx response while exiting zero. add and register a focused adapter regression test.
why
fork run 33150824247 looked successful at the workflow level, but the main harness output was only
HTTP 400: modelCode: does not exist. hermes exited zero, so the adapter wrapped that error text in a success envelope; the scorer then repeated the same error and no health score was recorded.the exact model source was traced to stale captured config:
model.default: tencent/hy3:free. the official live nous catalog updated 2026-08-28 containstencent/hy3and notencent/hy3:free.RH_MODEL_ARG=defaultwas not passed to hermes because the adapter already suppresses that sentinel.fix
verification
mutation with only the detection removed:
restored:
real fork dispatch 33189422348 now fails at the run step with:
this pr fixes false-green classification. selecting a current nous model and refreshing
HERMES_AUTHremains an operator credential/configuration action; the adapter does not silently rewrite it.