Conversation
The v6.12.1 > v6.13.1 migration added `_tooltip._position` with an empty string `''`. `_position` was introduced in v6.13.1 (commit 7831ee3) already carrying an enum and a `'bottom'` default; `''` is not a permitted enum value, so migrated content fails modern-schema validation (e.g. on AAT import: `/_items/N/_tooltip/_position must be equal to one of the allowed values`). The migration's own test passed only because its checkContent asserted the same invalid `''`. Set `_position` to the schema default `'bottom'` in both the mutate and the matching check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
taylortom
approved these changes
Jun 24, 2026
ethan-lp
approved these changes
Jul 20, 2026
lemmyadams
approved these changes
Jul 20, 2026
github-project-automation
Bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
|
🎉 This PR is included in version 6.20.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #370
Fix
v6.12.1 > v6.13.1migration inmigrations/v6.jsset_tooltip._positionto an empty string''._positionwas introduced in v6.13.1 already carrying anenumand a"bottom"default, so''is not a permitted value and migrated content fails modern-schema validation (/_items/N/_tooltip/_position must be equal to one of the allowed values)._positionto the schema default'bottom'in both themutateContentand the matchingcheckContent. The migration's own check previously passed only because it asserted the same invalid''.Testing
grunt migration:test --file=adapt-contrib-hotgraphic_position('bottom').