Skip to content

Use fully qualified std::env in clipboard detection - #10

Merged
adambuchweitz merged 1 commit into
mainfrom
feature/clipboard-env-fix
Apr 23, 2026
Merged

adambuchweitz merged 1 commit into
mainfrom
feature/clipboard-env-fix

Conversation

@adambuchweitz

@adambuchweitz adambuchweitz commented Apr 23, 2026 •

Copy link
Copy Markdown
Owner
  • Remove the local env import
  • Keep Wayland and X11 detection unchanged

Summary by CodeRabbit

  • Refactor
    • Updated clipboard detection for UNIX systems to use fully-qualified function references instead of module imports, improving code consistency while maintaining all existing functionality with no user-facing changes.

- Remove the local `env` import
- Keep Wayland and X11 detection unchanged
@coderabbitai

coderabbitai Bot commented Apr 23, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 95bfee92-7552-4f83-a127-5fd42cbf9b4d

📥 Commits

Reviewing files that changed from the base of the PR and between aa35a6f and 8c1e302.

📒 Files selected for processing (1)
  • src/clipboard.rs

📝 Walkthrough

Walkthrough

A refactoring change in UNIX clipboard detection that replaces a local std::env import with fully-qualified std::env::var_os(...) calls. Functional behavior remains unchanged; only the module reference pattern was modified.

Changes

Cohort / File(s) Summary
Import refactoring
src/clipboard.rs
Removed local use std::env; import and converted all env::var_os(...) calls to fully-qualified std::env::var_os(...) calls for Wayland/X11 environment variable checks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing a local import with fully-qualified std::env calls in clipboard detection code.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/clipboard-env-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@adambuchweitz
adambuchweitz merged commit 0ba1daf into main Apr 23, 2026
5 checks passed
@adambuchweitz
adambuchweitz deleted the feature/clipboard-env-fix branch April 23, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant