refactor: remove root config duplicates and financial domain - #17
Merged
Conversation
Root config/ files were outdated duplicates of src/dicterrors/config/. All production code uses factory methods that load from the package directory. Replaced file-path lookup in custom_domain_file.py with DomainConfig.legal() factory call. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Not relevant to the project's core use case (Indic language ASR for legal/medical transcription). Removes DomainConfig.financial(), the bundled financial_terms.txt config, and all references in docs and examples. Inline examples updated to use a generic custom domain. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/directory (duplicatedsrc/dicterrors/config/without staying in sync)DomainConfig.financial()factory method, bundledfinancial_terms.txt, and all references — not relevant to the project's core use case (Indic language ASR for legal/medical transcription)examples/custom_domain_file.pyto use factory methods instead of file-path lookups