Tidyup - #21
Merged
Merged
Tidyup#21
Conversation
Wanted something that shows the tool finds gadgets by watching the target, not by matching a name against a list. Added a fixture whose property (zqxkvBlorple) isn't in any of them - not the seed dictionary, the known-gadget DB, or the gate list - and a test that runs it through discovery, the differential oracle, and the reproduction gate and checks it still gets found and reproduced. Wrote up the seeds-vs-mechanism split in the architecture doc and linked it from the README.
import-source, require-main and require-node-options were sitting in the corpus as 'not verified' repro entries, which felt like a cop-out. Swapped them for behavioral probes that import/require the real module clean vs polluted and compare a fingerprint, so the mitigated/fixed verdicts get checked every run - if one ever comes back the fingerprint changes and the run catches it. Dropped probeImport/probeRequireDir, nothing uses them now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
npm run lintpassesnpm run test:cipasses(no heuristic-only reports — see CONTRIBUTING.md)
docs/configuration.md)
Notes for reviewers