Skip to content

support multiple tours with some not run#68

Open
jjb wants to merge 1 commit into
actmd:masterfrom
jjb:support-multiple-tours-with-some-not-run
Open

support multiple tours with some not run#68
jjb wants to merge 1 commit into
actmd:masterfrom
jjb:support-multiple-tours-with-some-not-run

Conversation

@jjb

@jjb jjb commented Mar 24, 2022

Copy link
Copy Markdown

before this, if a tour was encountered where tourMayStart
was false, then subsequent tours were not attempted

now, all incomplete tours are looped through until the first
runable one is run

for...in is used because it is the most compatible

example tour that this fix accommodates:

non_admin_intro:
  steps:
    1:
      text: "Welcome User!"
      attachTo:
        element: "#non-admin-tour"

admin_intro:
  steps:
    1:
      text: "Welcome Admin!"
      attachTo:
        element: "#admin-tour"

before this, if a tour was encountered where tourMayStart
was false, then subsequent tours were not attempted

now, all incomplete tours are looped through until the first
runable one is run

for...in is used because it is the most compatible
@jjb

jjb commented Oct 23, 2024

Copy link
Copy Markdown
Author

@canderson180 @aashishpsaini wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant