Repository navigation
Gate Agent answers on native citation checks - #423
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Block final Agent answers when any native citation binding fails, including the last tool turn. Tool submissions and direct JSON readers now share one finalizer over the existing evidence-check API. Retain rejected drafts and verdicts, allow correction only within the existing workflow budget, and return the checked object without another model rewrite.
Include the completed ELF/OpenViking/RAGFlow comparison and reuse assessment requested with this change. Most added lines are frozen test evidence, not product code. Preserve the original ELF result of 13/13 semantic answers and 12/13 with valid quotes; do not replace it with the correction result.
Alignment
This implements the source integrity and traceability requirements in
docs/spec/agent_memory_knowledge_system_v1.md. The observed Cobalt quotation inserted an ellipsis; the native checker rejected it, but the host did not consistently enforce that result. No source, model, embedding dimension, store, or retrieval behavior changes. External MCP clients still need their own final-output hook; publishing instructions does not install one.Validation
cargo make test-benchmark-runner-contract: 222 tests passed, including last-turn rejection, incomplete verdicts, unavailable checks, and unchanged accepted answer snapshots.cargo make check: passed (479 Rust tests, 222 runner-contract tests, 4 tooling tests; 111 environment-dependent Rust tests skipped locally). Documentation, formatting, Clippy, workflow lint, artifact manifests, and tested implementation hashes verified. PR integration, E2E, trace, and CodeQL checks must pass before merge.The new replay verifies final-output enforcement. It is not a fresh competitive benchmark, semantic-verification guarantee, or customer acceptance.