feat: add wallet activity feed endpoint (#424)#438
Merged
Chucks1093 merged 1 commit intoJun 23, 2026
Conversation
- Add GET /wallets/:address/activity endpoint for full trade history - Returns paginated list of trade events with type, creator info, amount, price, fee, ledger sequence, and timestamp - Supports type filter (buy|sell) and creator_id filter - Default sort is most recent first (reverse chronological) - Returns 400 for malformed Stellar addresses - Returns empty array (not 404) for wallets with no activity - Includes comprehensive integration tests covering all acceptance criteria - Route registered at /api/v1/wallets/:address/activity - Updated API inventory documentation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #424
Acceptance Criteria ✅ All Met
Returns all buy and sell events for the wallet in reverse chronological order
KEY_BOUGHTandKEY_SOLDactivity typescreatedAt: 'desc'(most recent first)Each event includes the price and fee at the time of the trade
price_at_trade,fee_paid, andledger_sequencefrom stored payloadtype=buy or type=sell filter returns only matching events
typemapped to internal ActivityType enumcreator_id filter returns only trades for that creator
creator_idadded to where clauseReturns empty array (not 404) for a valid wallet with no activity
[[], 0]when no rows foundReturns 400 for a malformed Stellar address
StellarAddressSchemafor validationPagination works correctly across large trade histories
Integration test covers: mixed history, type filter, creator filter, empty wallet