fix(web): align login page with dashboard design system - #243
Merged
mergekeeper[bot] merged 1 commit intoAug 26, 2026
Merged
Conversation
|
@ajulaybeeb is attempting to deploy a commit to the ACCENSA Team on Vercel. A member of the Team first needs to authorize it. |
|
@ajulaybeeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
MergeKeeper review Scope: in scope for linked issue The pull request successfully aligns the login page with the dashboard design system, removes undeclared tokens, updates the UI correctly, and includes appropriate tests. Reviewed commit: |
|
Merged Merged with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/dashboardand/verify.rounded-*classes withPageContainer,bg-grid, translucent backdrop blur panels, sharp corners, slate/emerald palettes, uppercase tracking-widest typography, and consistent error alert styling.Why
bg-card,text-muted-foreground,bg-primary,text-destructive,bg-secondary,text-primary-foreground,rounded-lg, etc.).@themeinglobals.css. They resolved to nothing, meaning the page suffered from unstyled fallback rendering bugs.PageContainerandbg-gridcreated an abrupt visual disconnect when transitioning from login into the dashboard.Implementation
apps/web/src/app/login/page.tsx:PageContainer width="narrow"withbg-gridbackground.bg-white/50 dark:bg-white/5 backdrop-blur-2xl) with sharp edges and subtle emerald glow.tracking-[0.25em] text-emerald-600 dark:text-emerald-400 font-bold text-xsuppercase category kicker.border-red-200 dark:border-red-500/20 bg-red-50 dark:bg-[#0a111a] text-red-600 dark:text-red-400).aria-busyand loading spinner state.apps/web/src/app/login/login-page.test.tsx:rounded-*styles.Testing
pnpm format:check(All matched files use Prettier code style)pnpm --filter web lint(0 errors)pnpm --filter web typecheck(0 errors)pnpm --filter web test(20 test files, 250 passed)pnpm --filter web build(Next.js production build completed successfully)Scope / Risk
apps/web/src/app/login/page.tsxand accompanying test suite.Issue
Closes #197