Skip to content

fix: [CODE-5062] Pre-Receive hook should not consider bypass flag for push rules #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [CODE-5062] Pre-Receive hook should not consider bypass flag for push rules #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions app/services/protection/rule_push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ func (p *Push) PushVerify(
return PushVerifyOutput{}, nil, fmt.Errorf("file size limit verify error: %w", err)
}

bypassable := p.Bypass.matches(ctx, in.Actor, in.IsRepoOwner, in.ResolveUserGroupID)
for i := range violations {
violations[i].Bypassable = bypassable
violations[i].Bypassed = bypassable
violations[i].Bypassable = false
violations[i].Bypassed = false
}

return out, violations, nil
Expand Down Expand Up @@ -87,9 +86,8 @@ func (p *Push) Violations(
)
}

bypassable := p.Bypass.matches(ctx, in.Actor, in.IsRepoOwner, in.ResolveUserGroupID)
violations.Bypassable = bypassable
violations.Bypassed = bypassable
violations.Bypassable = false
violations.Bypassed = false

return PushViolationsOutput{
Violations: []types.RuleViolations{violations},
Expand Down