Repository navigation
Conversation
Silence unused parameters, drop an unused audio thread function, use size_t-correct comparisons and format specifiers, avoid casting pointers to GQuark directly, and handle APRIL_RESULT_UNKNOWN in the result switch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- AdwPreferencesWindow -> AdwPreferencesDialog, presented without a parent so it still opens as its own window rather than inside the small captions window. AdwAboutWindow -> AdwAboutDialog. - GtkMessageDialog and AdwMessageDialog -> AdwAlertDialog. - GtkFileChooserNative -> GtkFileDialog for loading models and exporting history. - gtk_show_uri -> GtkUriLauncher / GtkFileLauncher. - gtk_css_provider_load_from_data -> load_from_string, and add the window's provider for the display instead of via GtkStyleContext. - G_APPLICATION_FLAGS_NONE -> G_APPLICATION_DEFAULT_FLAGS. GTK deprecated its X11 backend without replacements for the gdk_x11_* accessors used to keep the window above others, so those warnings are silenced around that one function only. Requires GTK 4.12 and libadwaita 1.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Time with the monotonic clock and stop early once the result can no longer reach MINIMUM_BENCHMARK_RESULT, instead of after a fixed 55 s. - Run one untimed warm-up second so one-off initialization does not count against the result, and flush at the end so buffered audio is included. - Feed 100 ms chunks so the progress bar moves smoothly, and fill it on completion. - Pass progress and the result to the main thread by value instead of through volatile fields shared between threads. - Keep the window alive while the benchmark thread runs, and stop and join the thread when the window goes away; closing the window mid-benchmark could previously crash. - Report a failing result instead of asserting when no model is loaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Point the submodule at april-asr with fixes for worker wakeups, flush handling, feature extraction and model validation (see the april-asr commit for details). Captions now finalize after 1.2 s of silence instead of 2.2 s. Switch the session to APRIL_CONFIG_FLAG_ASYNC_NO_RT_BIT so audio is no longer time-compressed when the CPU falls behind, which degraded accuracy. Enable C++ in the Meson project because april-asr's CMake project now builds its C++ examples with C++17. On 80 LibriSpeech test-clean/test-other clips (1,601 words) with the English model, word errors went from 215 to 201. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes compiler warnings, ports away from deprecated GTK and libadwaita APIs, reworks the setup benchmark, and updates april-asr with streaming and accuracy fixes. Each commit builds on its own.
Commits
APRIL_RESULT_UNKNOWN.AdwPreferencesDialog, presented without a parent so they still open in their own window rather than inside the small captions window.AdwAboutDialog, alerts useAdwAlertDialog, and file choosers useGtkFileDialog.GtkUriLauncherandGtkFileLauncher. CSS loads withload_from_stringthrough a display provider.G_APPLICATION_DEFAULT_FLAGSreplacesG_APPLICATION_FLAGS_NONE.gdk_x11_*keep-above accessors have no replacement, so their warnings are silenced around that one function only.volatilefields.APRIL_CONFIG_FLAG_ASYNC_NO_RT_BIT, so audio is no longer time-compressed when the CPU falls behind, which hurt accuracy. The trade-off is that a machine too slow for real time getsCANT_KEEP_UPerrors instead of degraded text. Happy to drop this if you prefer the old behaviour.Testing
🤖 Generated with Claude Code