Fix node8 github action - #172
Merged
Merged
Conversation
Author
|
Requested from #171 |
Author
|
Build fails due to linter, as on master branch: https://github.com/abandonware/noble/runs/1768999112 |
rzr
requested changes
Feb 13, 2021
| run: | | ||
| if [ ${{ matrix.node }} = 6 ]; then | ||
| # ESLint 6+ is not compatible with Node 6 | ||
| if [ ${{ matrix.node }} = 8 ]; then |
There was a problem hiding this comment.
keep node6 lines and add elif I will merge it
Author
There was a problem hiding this comment.
Even if node 6 is not on github actions ci file?
There was a problem hiding this comment.
it will preserve the legacy info and the comment wont be lost
but it's a not a big deal
atrovato
force-pushed
the
github-actions-node-8
branch
from
February 14, 2021 14:10
c1c9828 to
dbf350f
Compare
Author
|
I don't understand' what do you mean by "pin OS release"? |
|
replace latest by current versions well it's not a big deal let's focus on open PR 1st :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split of #171