add type validation and some brief descriptions for better-comments.tags (configuration of the extension) - #400
Open
Take-Me1010 wants to merge 3 commits into
Conversation
Author
|
for the property color, we can set not only #FFFFFF like style but also #FFFFFFAA or #RGB styles. So this PR need to reflect them. In addition, the properties color and backgroundColor seem not to be required. I will modify them in a day or so. |
Author
|
Now I modified color validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, the extension better-comments is really useful and I have used it for 2 years! Thanks!!
This PR includes JSON schema and some brief descriptions for configurations of
better-comments.tags.This PR will allow users to more easily review and customize the settings of tags!
In the schema, the properties required are
tag,color, andbackgroundColorbecause these properties seem essential in the source code. If not correct, I will modify it.